prevent slice::from_raw_parts from being passed a null pointer#1380
Open
z-erica wants to merge 1 commit into
Open
prevent slice::from_raw_parts from being passed a null pointer#1380z-erica wants to merge 1 commit into
z-erica wants to merge 1 commit into
Conversation
when nfont is zero in a FcFontSet, the fonts field can be a null pointer.
this can make the test suite panic:
thread 'trip_test' (7786) panicked at crates/bridge_fontconfig/src/font_set.rs:23:18:
unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`
This indicates a bug in the program. This Undefined Behavior check is optional, and cannot be relied on for safety.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread caused non-unwinding panic. aborting.
this fix maintains the safety invariant by always returning an empty
slice with a lifetime of 'static when the array is empty
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1380 +/- ##
==========================================
- Coverage 29.86% 29.86% -0.01%
==========================================
Files 273 273
Lines 180535 180537 +2
Branches 180535 180537 +2
==========================================
Hits 53909 53909
- Misses 54411 54412 +1
- Partials 72215 72216 +1
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when nfont is zero in a FcFontSet, the fonts field can be a null pointer. this can make the test suite panic:
this fix maintains the safety invariant by always returning an empty slice with a lifetime of 'static when the array is empty